Merged
Conversation
rimi-itk
reviewed
Oct 24, 2024
Contributor
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
Very good stuff. Some minor changes requested and some suggestions added.
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…ervices.yml Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
rimi-itk
approved these changes
Oct 25, 2024
Comment on lines
+11
to
+16
| "repositories": [ | ||
| { | ||
| "type": "composer", | ||
| "url": "https://packages.drupal.org/8" | ||
| } | ||
| ], |
Contributor
There was a problem hiding this comment.
This makes composer.json not normalized; I think we need to add --dry-run in https://github.com/itk-dev/ai-screening/blob/feature/hooks/.github/workflows/pr.yml#L48:
docker compose run --user root --rm phpfpm composer normalize --dry-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ai_screening_project module