Skip to content

Feature/2874 side menu with projects entry#20

Merged
yepzdk merged 9 commits intodevelopfrom
feature/2874-side-menu-with-projects-entry
Nov 1, 2024
Merged

Feature/2874 side menu with projects entry#20
yepzdk merged 9 commits intodevelopfrom
feature/2874-side-menu-with-projects-entry

Conversation

@sinejespersen
Copy link
Copy Markdown

Link to ticket

2874

Description

  • Add site branding block to navigation
  • Remove field_ui from core.extension.yml and a config file
  • Remove the menu link created in the view of /projects, and add the link in the menu configuration (because there was a weird bug where in_active_trail did not change to true even if the menu-item was selected)
  • Add menu_ui, field_ui and views_ui to ignored the list of modules excluded from import/export in settings.php
  • Style the menu with tailwind!
  • Add description and authored_by to the projects view, and remove the labels

Screenshot of the result

image

<div class="fixed top-20 z-10 left-0 right-0 px-1">
{{ page.content.itkdev_base_theme_messages }}
</div>
{# <div class="fixed top-20 z-10 left-0 right-0 px-1">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this left for later on purpose?

Copy link
Copy Markdown
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a single comment.

Comment on lines +53 to +55
{# <div class="fixed top-20 z-10 left-0 right-0 px-1">
{{ page.content.itkdev_project_theme_messages }}
</div> #}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused code.

@yepzdk yepzdk merged commit a9a92db into develop Nov 1, 2024
@yepzdk yepzdk deleted the feature/2874-side-menu-with-projects-entry branch November 1, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants