Merged
Conversation
added 14 commits
November 6, 2024 14:48
sinejespersen
force-pushed
the
feature/2903-projects-list
branch
from
43915be to
da059d4
Compare
sinejespersen
commented
Nov 7, 2024
…ents/tablesort-indicator.html.twig
rimi-itk
requested changes
Nov 7, 2024
Contributor
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
Looks good. Some comments and suggestions added.
| ``` | ||
|
|
||
| ## Delvelopment command line incantations | ||
| ## Development command line incantations |
Comment on lines
+16
to
+17
| This ensures that, if clean URLs are off, the 'q' is added first, | ||
| as a hidden form element, so that it shows up first in the POST URL. |
Contributor
There was a problem hiding this comment.
Are you sure? If you POST you don't add anything to the URL. Do you mean GET? You should always use GET to get stuff (Drupal breaks this rule in multiple places).
Author
There was a problem hiding this comment.
I am not sure. I copy pasted this solely to add the grid classes to <form.... should I change the comment to GET?
Contributor
There was a problem hiding this comment.
Can't (better) exposed filters add the css class names? And make sure that you GET?
…ents/form-element.html.twig Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
…view.html.twig Co-authored-by: Mikkel Ricky <rimi@aarhus.dk>
rimi-itk
reviewed
Nov 7, 2024
| <a href="/node/add/project" class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center" data-drupal-link-system-path="node/add/project"> | ||
| {% set path = path('node.add', {node_type: 'project'}) %} | ||
|
|
||
| <a href={{ path }} class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center" data-drupal-link-system-path="node/add/project"> |
Contributor
There was a problem hiding this comment.
What is the data-drupal-link-system-path attribute used for? Should it be set using path?
Suggested change
| <a href={{ path }} class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center" data-drupal-link-system-path="node/add/project"> | |
| <a href={{ path }} class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center" data-drupal-link-system-path="{{ path }}"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <a href={{ path }} class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center" data-drupal-link-system-path="node/add/project"> | |
| <a href="{{ path }}" class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center"> |
sinejespersen
commented
Nov 8, 2024
| } | ||
|
|
||
| /* This css class is added on the projects view (admin/structure/views/view/projects) */ | ||
| .projects-view { |
Author
There was a problem hiding this comment.
This looks as so, and will change in a later pr
rimi-itk
approved these changes
Nov 8, 2024
| <a href="/node/add/project" class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center" data-drupal-link-system-path="node/add/project"> | ||
| {% set path = path('node.add', {node_type: 'project'}) %} | ||
|
|
||
| <a href={{ path }} class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center" data-drupal-link-system-path="node/add/project"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <a href={{ path }} class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center" data-drupal-link-system-path="node/add/project"> | |
| <a href="{{ path }}" class="font-thin bg-green-700 hover:bg-green-600 text-white py-2 px-4 rounded inline-flex items-center"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/dashboard/show#/tickets/showTicket/2903
Description
Screenshot of the result