Conversation
yepzdk
reviewed
Nov 18, 2024
Contributor
yepzdk
left a comment
yepzdk
left a comment
There was a problem hiding this comment.
A screenshot and ticket link is missing in the PR description.
A couple of comments on reusing tailwind classes to keep colours consistant.
| } | ||
|
|
||
| .webform-progress .progress-step { | ||
| color: rgba(0,0,0,.3); |
Contributor
There was a problem hiding this comment.
Could the color be applied with a tailwind class on the markup? Maybe using the secondary color.
| color: rgba(0,0,0,.3); | ||
|
|
||
| &.is-complete { | ||
| color: #047857; |
Contributor
There was a problem hiding this comment.
Could the color be applied with a tailwind class on the markup? Maybe using the brand color?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
Please add a link to the ticket being addressed by this change.
Description
Please include a short description of the suggested change and the reasoning behind the approach you have chosen.
Screenshot of the result
If your change affects the user interface you should include a screenshot of the result with the pull request.
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.