Merged
Conversation
rimi-itk
force-pushed
the
feature/2991-breadcrumb-trail
branch
3 times, most recently
from
c252106 to
37fd880
Compare
rimi-itk
force-pushed
the
feature/2991-breadcrumb-trail
branch
from
37fd880 to
39ff016
Compare
| <li> | ||
| {% if item.url %} | ||
| <a class="font-semibold" href="{{ item.url }}">{{ item.text }}</a> <span>/</span> | ||
| <a class="{{ loop.last ? 'text-green-700' }} font-semibold" href="{{ item.url }}">{{ item.text }}</a> |
sinejespersen
approved these changes
Nov 19, 2024
sinejespersen
left a comment
sinejespersen
left a comment
There was a problem hiding this comment.
Why are you editing both breadcrumb.html.twig?
Contributor
Author
Because they both would not render a trail separator in the very rare – probably even never occurring – case when an item has no URL. |
martinyde
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/TimeTable/TimeTable?showTicketModal=2991#/tickets/showTicket/2991
Description
Screenshot of the result
Project create:
Project view:
Project edit:
Project track view/edit:
Project track tool view (this needs some additional work):
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.