Skip to content

Added Yes/No stop webform element#82

Merged
martinyde merged 2 commits intodevelopfrom
feature/jura-er-slet-ikke-komplekst
Jan 23, 2025
Merged

Added Yes/No stop webform element#82
martinyde merged 2 commits intodevelopfrom
feature/jura-er-slet-ikke-komplekst

Conversation

@rimi-itk
Copy link
Copy Markdown
Contributor

@rimi-itk rimi-itk commented Jan 22, 2025

Link to ticket

https://leantime.itkdev.dk/TimeTable/TimeTable?showTicketModal=3656#/tickets/showTicket/3656

Description

Adds Yes/no stop webform element. Enables “webform_markup” element to make it possible to add static text on a form.

Still missing:

  • Rendering on submission result page
  • Styling

Screenshot of the result

Editing a yes/no/stop element:

Screen Shot 2025-01-23 at 11 07 44

Result on form (with 4 different yes/no/stop elements):

Screen Shot 2025-01-23 at 10 14 21

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@rimi-itk rimi-itk force-pushed the feature/jura-er-slet-ikke-komplekst branch 5 times, most recently from 07ba424 to a3be474 Compare January 23, 2025 09:22
@rimi-itk rimi-itk force-pushed the feature/jura-er-slet-ikke-komplekst branch 2 times, most recently from 7ee70bc to ae8b280 Compare January 23, 2025 10:03
@rimi-itk rimi-itk force-pushed the feature/jura-er-slet-ikke-komplekst branch from ae8b280 to ac5c9b3 Compare January 23, 2025 10:06
@rimi-itk rimi-itk marked this pull request as ready for review January 23, 2025 10:09
@rimi-itk rimi-itk requested a review from martinyde January 23, 2025 10:09
@rimi-itk rimi-itk changed the title Added Yes/No/Stop webform element Added Yes/No stop webform element Jan 23, 2025
@martinyde martinyde merged commit dcb1b6f into develop Jan 23, 2025
@martinyde martinyde deleted the feature/jura-er-slet-ikke-komplekst branch January 23, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants