Skip to content

Hotfix/5566 maintenance contract merge from main#74

Merged
martinyde merged 91 commits into
feature/5566_maintenance_contract-from
hotfix/5566_maintenance_contract-merge-from-main
May 19, 2026
Merged

Hotfix/5566 maintenance contract merge from main#74
martinyde merged 91 commits into
feature/5566_maintenance_contract-from
hotfix/5566_maintenance_contract-merge-from-main

Conversation

@martinyde
Copy link
Copy Markdown
Contributor

Link to ticket

Please add a link to the ticket being addressed by this change.

Description

Please include a short description of the suggested change and the reasoning behind the approach you have chosen.

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

turegjorup and others added 30 commits March 19, 2026 10:45
Upgrade easycorp/easyadmin-bundle from 4.x to 5.x and
doctrine/doctrine-migrations-bundle from 3.x to 4.x.

EasyAdmin 5 breaking changes addressed:
- Add #[AdminDashboard] attribute, remove #[Route] from index()
- Replace MenuItem::linkToCrud() with MenuItem::linkTo()
- Update FieldInterface::new() signature in all 14 custom fields
- Replace CrudControllerRegistry with AdminControllerRegistryInterface
- Replace ea. global variable with ea() function in templates

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add vendor-neutral agents.md with project context for AI coding agents,
and Claude Code settings with permissions, hooks, and plugins. Update
README with AI coding agents section describing the setup.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Migrate Serializer\Annotation to Serializer\Attribute namespace (9 entities)
- Remove eraseCredentials() from User and Server (removed from UserInterface)
- Set explicit default_protocol on UrlType (default changed to null)
- Fix routing resources from .xml to .php (framework, web_profiler)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tection

Replace the old api-spec.yml (Java-based openapitools/openapi-diff, task runner)
with a new api-spec.yaml using oasdiff (Go, FOSS). Fixes file name mismatch
(spec.yaml -> api-spec-v1.yaml), uses docker compose pattern, and adds path
filtering. Remove redundant apispec job from pr.yaml.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…aliases

- Exclude config/reference.php from php-cs-fixer (generated file triggers
  false positive from phpdoc_no_alias_tag rule)
- Add cs: aliases to all coding-standards tasks in Taskfile

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
turegjorup and others added 24 commits April 7, 2026 13:47
- composer update (PHPStan 2.1.46 → 2.1.54, rector 2.4.0 → 2.4.2,
  symfony components, ergebnis tooling, etc.)
- Regenerate config/reference.php (Symfony component updates)
- Regenerate public/api-spec-v1.{yaml,json} (status field number → integer)
- Fix pre-existing PHPDoc typo in GitRepoRepository
  (<GitTagRepository> → <GitRepo>) caught by updated PHPStan

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

API Specification - Breaking changes detected

API Changelog 0.0.0 vs. 1.0.0

API Changes

POST /api/detection_results

  • ⚠️ request property type was restricted to a list of enum values (media type: application/ld+json)
  • ⚠️ request property type was restricted to a list of enum values (media type: application/json)
  • ⚠️ the type request property type/format changed from string/to/`` (media type: application/json)
  • ⚠️ the type request property type/format changed from string/to/`` (media type: application/ld+json)
  • ⚠️ removed the media type application/json for the response with the status 202
  • ⚠️ removed the media type application/ld+json for the response with the status 202
  • ⚠️ the response property status became nullable for the status 400 (media type: application/json)
  • ⚠️ the response property status became nullable for the status 400 (media type: application/ld+json)
  • ⚠️ the response property status became nullable for the status 400 (media type: application/problem+json)
  • ⚠️ the status response's property type/format changed from number/ to `integer, null`/ for status 400 (media type: application/problem+json)
  • ⚠️ the status response's property type/format changed from number/ to `integer, null`/ for status 400 (media type: application/json)
  • ⚠️ the status response's property type/format changed from number/ to `integer, null`/ for status 400 (media type: application/ld+json)
  • the type request property default value `` was removed (media type: application/json)
  • the type request property default value `` was removed (media type: application/ld+json)
  • added the new dir enum value to the request property type (media type: application/ld+json)
  • added the new dir enum value to the request property type (media type: application/json)
  • added the new docker enum value to the request property type (media type: application/ld+json)
  • added the new docker enum value to the request property type (media type: application/json)
  • added the new drupal enum value to the request property type (media type: application/ld+json)
  • added the new drupal enum value to the request property type (media type: application/json)
  • added the new git enum value to the request property type (media type: application/json)
  • added the new git enum value to the request property type (media type: application/ld+json)
  • added the new nginx enum value to the request property type (media type: application/ld+json)
  • added the new nginx enum value to the request property type (media type: application/json)
  • added the new symfony enum value to the request property type (media type: application/ld+json)
  • added the new symfony enum value to the request property type (media type: application/json)
  • added the non-success response with the status 401
  • added the non-success response with the status 403
  • added the optional property violations/items/code to the response with the 422 status (media type: application/json)
  • added the optional property violations/items/code to the response with the 422 status (media type: application/ld+json)
  • added the optional property violations/items/code to the response with the 422 status (media type: application/problem+json)
  • added the optional property violations/items/hint to the response with the 422 status (media type: application/problem+json)
  • added the optional property violations/items/hint to the response with the 422 status (media type: application/json)
  • added the optional property violations/items/hint to the response with the 422 status (media type: application/ld+json)
  • added the optional property violations/items/payload to the response with the 422 status (media type: application/json)
  • added the optional property violations/items/payload to the response with the 422 status (media type: application/ld+json)
  • added the optional property violations/items/payload to the response with the 422 status (media type: application/problem+json)
  • the response property violations/items/message became required for the status 422 (media type: application/json)
  • the response property violations/items/message became required for the status 422 (media type: application/problem+json)
  • the response property violations/items/message became required for the status 422 (media type: application/ld+json)
  • the response property violations/items/propertyPath became required for the status 422 (media type: application/json)
  • the response property violations/items/propertyPath became required for the status 422 (media type: application/problem+json)
  • the response property violations/items/propertyPath became required for the status 422 (media type: application/ld+json)

Components

  • removed the schema ConstraintViolation-json
  • removed the schema ConstraintViolation.jsonld-jsonld

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2026

Codecov Report

❌ Patch coverage is 22.61484% with 219 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.79%. Comparing base (a884b26) to head (514260b).

Files with missing lines Patch % Lines
src/Entity/SecurityContract.php 0.00% 88 Missing ⚠️
src/Service/ServiceAgreementSyncService.php 1.88% 52 Missing ⚠️
...ontroller/Admin/SecurityContractCrudController.php 2.32% 42 Missing ⚠️
src/Command/SyncServiceAgreementsCommand.php 0.00% 10 Missing ⚠️
src/OpenApi/OpenApiFactory.php 10.00% 9 Missing ⚠️
src/Entity/Advisory.php 0.00% 7 Missing ⚠️
src/Admin/Field/ClonedByField.php 0.00% 2 Missing ⚠️
src/Twig/AppExtension.php 33.33% 2 Missing ⚠️
src/Form/Type/ServiceCertificate/ServiceType.php 0.00% 1 Missing ⚠️
src/Handler/DockerImageHandler.php 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@                            Coverage Diff                            @@
##             feature/5566_maintenance_contract-      #74       +/-   ##
=========================================================================
+ Coverage                                 11.13%   34.79%   +23.65%     
- Complexity                                  912      915        +3     
=========================================================================
  Files                                       132      128        -4     
  Lines                                      2891     2808       -83     
=========================================================================
+ Hits                                        322      977      +655     
+ Misses                                     2569     1831      -738     
Flag Coverage Δ
unittests 34.79% <22.61%> (+23.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martinyde martinyde merged commit c023288 into feature/5566_maintenance_contract- May 19, 2026
14 of 21 checks passed
@martinyde martinyde deleted the hotfix/5566_maintenance_contract-merge-from-main branch May 19, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants