Skip excluded workers in workload report#258
Merged
jeppekroghitk merged 19 commits intofeature/new-leantime-apifrom Jan 7, 2026
Merged
Conversation
jeppekroghitk
changed the base branch from
develop
to
feature/new-leantime-api
tuj
requested changes
Jan 6, 2026
| } | ||
|
|
||
| foreach ($workers as $worker) { | ||
| $workerIncludedInReports = $worker->getIncludeInReports(); |
Contributor
There was a problem hiding this comment.
Instead of filtering out the workers at this stage I think you should limit the $worker array to begin with.
$workers = $this->workerRepository->findBy(["includeInReports" => true]);
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/new-leantime-api #258 +/- ##
===========================================================
Coverage ? 17.45%
Complexity ? 1678
===========================================================
Files ? 205
Lines ? 6955
Branches ? 0
===========================================================
Hits ? 1214
Misses ? 5741
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tuj
approved these changes
Jan 6, 2026
HourReport: Get issue epics via join
Include issue tags in sync
jeppekroghitk
deleted the
hotfix/ignore-unset-normtid-from-excluded-workers-in-reports
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
N/A
Description
Skip workers in workload report who are set to be excluded from reports.
Mock 'getIncludeInReports' in failing tests.
Screenshot of the result
N/A
Checklist