Skip to content

Added option to disable modifiedAt check for sync command#271

Merged
tuj merged 1 commit intorelease/3.0.1from
feature/disable-modified-check-for-sync
Feb 5, 2026
Merged

Added option to disable modifiedAt check for sync command#271
tuj merged 1 commit intorelease/3.0.1from
feature/disable-modified-check-for-sync

Conversation

@tuj
Copy link
Copy Markdown
Contributor

@tuj tuj commented Feb 5, 2026

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/6609

Description

  • Added option to disable modifiedAt check for sync command.
  • Refactored option names to constants.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@tuj tuj self-assigned this Feb 5, 2026
@tuj tuj added the enhancement New feature or request label Feb 5, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 34.84848% with 43 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/3.0.1@e5cb7ae). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Command/SyncCommand.php 0.00% 25 Missing ⚠️
src/Service/LeantimeApiService.php 62.50% 9 Missing ⚠️
src/Service/DataProviderService.php 50.00% 8 Missing ⚠️
src/MessageHandler/LeantimeUpdateHandler.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/3.0.1     #271   +/-   ##
================================================
  Coverage                 ?   17.62%           
  Complexity               ?     1689           
================================================
  Files                    ?      205           
  Lines                    ?     6985           
  Branches                 ?        0           
================================================
  Hits                     ?     1231           
  Misses                   ?     5754           
  Partials                 ?        0           
Flag Coverage Δ
17.62% <34.84%> (?)
unittests 17.62% <34.84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tuj tuj requested a review from rimi-itk February 5, 2026 06:13
Copy link
Copy Markdown
Contributor

@rimi-itk rimi-itk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment.

Comment on lines +26 to +33
private const OPTION_JOB = 'job';
private const OPTION_MODIFIED = 'modified';
private const OPTION_ALL = 'all';
private const OPTION_PROJECTS = 'projects';
private const OPTION_VERSIONS = 'versions';
private const OPTION_ISSUES = 'issues';
private const OPTION_WORKLOGS = 'worklogs';
private const OPTION_WORKERS = 'workers';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is epic, but we/you should look into “Invokable commands” (https://symfony.com/blog/new-in-symfony-7-3-invokable-commands-and-input-attributes, https://symfony.com/doc/7.4/console.html#console-input) for an even better solution.

@tuj tuj merged commit 29b1c45 into release/3.0.1 Feb 5, 2026
8 of 9 checks passed
@tuj tuj deleted the feature/disable-modified-check-for-sync branch February 5, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants