Skip to content

LOOP-1134: Added javascript to hide search filter when the is no search result #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinyde merged 2 commits into from
Nov 10, 2021
Merged

LOOP-1134: Added javascript to hide search filter when the is no search result #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30750b3
LOOP-1134: Added javascript to hide search filter when the is no sear…
martinyde Nov 3, 2021
d94d697
Merge branch 'develop' into feature/loop-1134-hide-search-filters
martinyde Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions web/profiles/custom/os2loop/modules/os2loop_search_db/assets/js/hideFilters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/**
* Hide search filters if the search yields no result.
*/
(function (Drupal, drupalSettings) {
'use strict';
Drupal.behaviors.hideFilters = {
attach: function (context, settings) {
let noResult = document.getElementById('js-no-result');
if (noResult) {
document.getElementById('js-search-filters').style.display = 'none';
}
}
};

})(Drupal, drupalSettings);
4 changes: 4 additions & 0 deletions web/profiles/custom/os2loop/modules/os2loop_search_db/os2loop_search_db.libraries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
hide-filters:
version: 1.x
js:
assets/js/hideFilters.js: {}
1 change: 1 addition & 0 deletions web/profiles/custom/os2loop/modules/os2loop_search_db/src/Helper/Helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ public function getContentTypeGroups(): array {
public function formAlter(array &$form, FormStateInterface $form_state, $form_id) {
if ('views_exposed_form' === $form_id
&& 'views-exposed-form-os2loop-search-db-page-search' === ($form['#id'] ?? NULL)) {
$form['#attached']['library'][] = 'os2loop_search_db/hide-filters';
// Add facet filter query to form to keep the filters when submitting
// search form.
$request = $this->requestStack->getCurrentRequest();
Expand Down
4 changes: 2 additions & 2 deletions ...oop_theme/templates/form/form--views-exposed-form-os2loop-search-db-page-search.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
*/
#}
{# @see https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Search_role#examples #}
<form{{ attributes.setAttribute('role', 'search') }} class="form" >
<form{{ attributes.setAttribute('role', 'search') }} class="form">
<div class="row">
{{ children }}
</div>
<div class="col-12">
<div class="col-12" id="js-search-filters">
<div class="row">
<div class="col ml-2 border-bottom">
<h6 class="d-inline align-middle p-0">{{ 'Search filters'|t }}</h6>
Expand Down
2 changes: 1 addition & 1 deletion .../os2loop/themes/os2loop_theme/templates/views/no-result-views-os2loop-search-db.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% set os2loop_settings = get_os2loop_config('os2loop_settings.settings') %}

<div class="col-12">
<div class="col-12" id="js-no-result">
<div class="mb-4">
<h2 class="h5">{{ 'Unfortunately your search yielded no result.'|t }}</h2>
<div class="d-block">{{ 'Check that you have spelled correctly or try another search term.'|t }}</div>
Expand Down