1712: Added “Expand all steps” link on step by step #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/1712-step-by-step
branch
2 times, most recently
from
682c2e8 to
27f4fda
Compare
rimi-itk
force-pushed
the
feature/1712-step-by-step
branch
from
27f4fda to
e734505
Compare
| </span> | ||
| {% else %} | ||
| <a class="collapsed step--collapse-toggle" type="button" data-toggle="collapse" data-target="#paragraph-id-{{ paragraph.id() }}"> | ||
| <a class="{{ class_collapsed }} step--collapse-toggle" type="button" data-toggle="{{ class_collapse }}" data-target="#paragraph-id-{{ paragraph.id() }}"> |
Author
There was a problem hiding this comment.
Because I didn't write the code. But it makes sense to change it.
Author
There was a problem hiding this comment.
The a element contains the step header (title) and a button element may not be appropriate for this use.
sinejespersen
approved these changes
Jun 27, 2024
rimi-itk
force-pushed
the
feature/1712-step-by-step
branch
from
69a5f43 to
a01a0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/dashboard/home#/tickets/showTicket/1712
Adds “Expand all steps” link to Step by step paragraphs.
Before:
After:
After clicking “Expand all steps”: