Feature/apply itkdev template #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rimi-itk
reviewed
Jul 2, 2025
| docker network create frontend | ||
| - run: | | ||
| docker compose run --rm prettier 'web/profiles/custom/os2loop/**/*.{css,scss}' --check |
There was a problem hiding this comment.
Would
Suggested change
| docker compose run --rm prettier 'web/profiles/custom/os2loop/**/*.{css,scss}' --check | |
| docker compose run --rm prettier 'web/*/custom/**/css/**/*.{css,scss}' --check |
work here? If so, we could make a small change in https://github.com/itk-dev/devops_itkdev-docker/blob/develop/github/workflows/drupal/styles.yaml#L36 for (more) a general solution.
Author
There was a problem hiding this comment.
Afraid not. The first * could work but the styling assets are not contained in a specific css folder
rimi-itk
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/404/#/tickets/showTicket/4829
Description
Additional comments or questions
The old site apparently couldn't be installed due to config setup. Removing ref: ${{ github.base_ref }} would allow the site action to pass, which suggests that after the update the site would install since config is changed.