Feature/subscriptions modify #50
Conversation
martinyde
commented
May 5, 2021
martinyde
commented
- Messages view update
- Message languages fix
- Cleanup templates
- Modify icon asstes
| $dark-upvote: darken($primary-color, 10%); | ||
| $dark-follow-content: darken($primary-color, 10%); | ||
| $dark-edit: darken($secondary-color, 10%); | ||
| $dark-subscribe: darken($primary-color, 10%); |
There was a problem hiding this comment.
This should be darken($subscribe, 10%); (in case $subscribe is set to something other than $primary-color).
| $dark-subscribe: darken($primary-color, 10%); | ||
| $dark-favourite: darken($primary-color, 10%); |
There was a problem hiding this comment.
This should be darken($favourite, 10%); (in case $favourite is set to something other than $primary-color).
| {% if action == 'unflag' %} | ||
| {% set action_class = 'unsubscribe' %} | ||
| {% else %} | ||
| {% set action_class = 'subscribe' %} | ||
| {% endif %} |
There was a problem hiding this comment.
Should be written as {% set action_class = action == 'unflag' ? 'unsubscribe' : 'subscribe' %}.
| {% set title = "About document"|t %} | ||
| {{ _self.title(title, "document", node, content) }} | ||
| {% endif %} | ||
| {{ macros.title("About document", "document", node, content) }} |
There was a problem hiding this comment.
"About document" must be translated, i.e. {{ macros.title("About document"|t, … }}.
| <div class="user"> | ||
| {% include '@os2loop_theme/field/user-image.html.twig' with {'uid': user.account.id} %} | ||
| {% include '@os2loop_theme/field/username.html.twig' with {'uid': user.account.id, 'account': logged_in_user} %} | ||
| {% include '@os2loop_theme/field/user-name.html.twig' with {'uid': user.account.id} %} | ||
| </div> |
There was a problem hiding this comment.
These 4 lines are duplicated in (at least) two template files and could be refactored into a shared template, user-info.html.twig, say. Furthermore, we should pass the entire user object to the template and let it get the parts it needs, e.g.
{% include '@os2loop_theme/user-info.html.twig' with {user: user} %}
There was a problem hiding this comment.
A user-info.html.twig has been added.
| <div class="col-md"> | ||
| <div> | ||
| <a href="{{ url('entity.user.canonical', {'user': uid}) }}">{{ account.os2loop_user_given_name.value }} {{ account.os2loop_user_family_name.value }}</a> | ||
| <a href="{{ url('entity.user.canonical', {'user': uid}) }}">{{ drupal_field('os2loop_user_given_name', 'user', uid)['#items'].0.value }} {{ drupal_field('os2loop_user_family_name', 'user', uid)['#items'].0.value }}</a> |
There was a problem hiding this comment.
Sometimes I hate Drupal! Do we really need ['#items'].0.value?
Can https://www.drupal.org/project/twig_field_value help clean this up?
There was a problem hiding this comment.
After a rewrite with user-info.html.twig, it was made possible to grab the values from the user entity instead of calling drupal_field(), that turns:
drupal_field('os2loop_user_given_name', 'user', uid)['#items'].0.value
into
user['#user'].os2loop_user_given_name.value
| /** | ||
| * @file | ||
| * Default theme implementation for displaying a username. | ||
| * Template for displaying a username. |
There was a problem hiding this comment.
Well, it actually displays a lot more. Maybe the comment should read “Template for displaying a user“ – or we could get rid of this template and the comment (cf. suggestion on inlining two templates).
| {% include '@os2loop_theme/field/user-image.html.twig' with {'uid': user['#user'].id} %} | ||
| {% include '@os2loop_theme/field/user-name.html.twig' with {'user': user} %} |
There was a problem hiding this comment.
If these two (small) templates are not used anywhere else I think we should just put their content into this template. If inlining is not possible, we should pass the full user object to user-image.html.twig for consistency.
Feature/BKL-75-AddHeaderToCreateQuestion
