Skip to content

Conversation

@rimi-itk
Copy link

@rimi-itk rimi-itk commented May 12, 2021

https://jira.itkdev.dk/browse/LOOP-894

TODO: We need to clean up the https://github.com/itk-dev/os2loop/blob/develop/web/profiles/custom/os2loop/themes/os2loop_theme/templates/field/field.html.twig template since it is way to liberal with assigning the os2loop-title css class.

Screen Shot 2021-05-12 at 18 32 13

Screen Shot 2021-05-12 at 22 38 37

@rimi-itk rimi-itk requested a review from sinejespersen May 12, 2021 16:27
border-top: none;
}

// @see search_api_autocomplete/css/search_api_autocomplete.css

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sloppy programming and missing clean up. Now the comment says what it's supposed to say.

@rimi-itk rimi-itk requested a review from sinejespersen May 15, 2021 07:52
@rimi-itk rimi-itk force-pushed the feature/LOOP-894-search-autocomplete-styling branch 2 times, most recently from 46bb120 to 625bcbb Compare May 18, 2021 11:21
@rimi-itk rimi-itk force-pushed the feature/LOOP-894-search-autocomplete-styling branch from 625bcbb to 9398ecf Compare May 18, 2021 11:23
@rimi-itk rimi-itk merged commit daeefbf into develop May 18, 2021
@rimi-itk rimi-itk deleted the feature/LOOP-894-search-autocomplete-styling branch May 18, 2021 11:26
rimi-itk added a commit that referenced this pull request Aug 12, 2022
rimi-itk pushed a commit that referenced this pull request Aug 12, 2022
)

Feature/BKL-93-RemoveIdFromAutocompleteInput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants