feature/ITSTYR 81 symfony6upgrade by Onkel-Martin · Pull Request #25 · itk-dev/sysstatus

Onkel-Martin · 2023-03-09T12:50:35Z

updated readme open statment
README updated for composer v.2, updated upload command command
made a minor change
ITSTYR-81 / 1. Installed new symfony project / copied new docker files over / FIRST COMMIT
testing mermaid on git
added a Flowchart over the entities
updatet readme with flowchart text
updatet readme with flowchart text 2
ITSTYR-81 added makerbundle

…s over / FIRST COMMIT

…ys in Category, Theme

…error

… to be deleted later

… and SmileyType

… now checking auth

… updated the smiley twig template

…asyadmin

…asyadmin... since the documentation states infinit loop

jekuaitk

Looks very good. Needs some cleanup after various debugging and the intense makeover/upgrade.

jekuaitk · 2025-01-02T09:08:42Z

+        "symfony/security-bundle": "6.4.*",
+        "symfony/validator": "6.4.*",
+        "symfony/yaml": "6.4.*",
+        "symfonycasts/verify-email-bundle": "^1.17"


Is this verification of email bundle used?

jekuaitk · 2025-01-02T09:09:18Z

    Knp\Bundle\PaginatorBundle\KnpPaginatorBundle::class => ['all' => true],
-    Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle::class => ['all' => true],
+    Symfony\Bundle\WebProfilerBundle\WebProfilerBundle::class => ['dev' => true, 'test' => true],
+    SymfonyCasts\Bundle\VerifyEmail\SymfonyCastsVerifyEmailBundle::class => ['all' => true],


See comment regarding verify email bundle in composer.json

jekuaitk · 2025-01-02T09:14:38Z

 services:
  phpfpm:
-    image: itkdev/php7.4-fpm:alpine
+    image: itkdev/php8.1-fpm:alpine


We could probably consider 8.3!

jekuaitk · 2025-01-02T09:18:02Z

 class Version20180424124131 extends AbstractMigration
 {
-    public function up(Schema $schema)
+    public function up(Schema $schema):void


I suppose our coding standards don't check migration files, but if we change old migration files we should probably modify them to be inline with how newly generated ones look. That is a space in between the colon and the return type.

Our coding standards should check all code we write, i.e. also the migrations.

jekuaitk · 2025-01-02T09:21:09Z

+    public function up(Schema $schema): void
+    {
+        // this up() migration is auto-generated, please modify it to your needs
+        $this->addSql('CREATE TABLE test_user (id INT AUTO_INCREMENT NOT NULL, username VARCHAR(180) NOT NULL, roles JSON NOT NULL COMMENT \'(DC2Type:json)\', password VARCHAR(255) NOT NULL, UNIQUE INDEX UNIQ_IDENTIFIER_USERNAME (username), PRIMARY KEY(id)) DEFAULT CHARACTER SET utf8mb4 COLLATE `utf8mb4_unicode_ci` ENGINE = InnoDB');


What is test_user?

jekuaitk · 2025-01-02T09:53:39Z

-use Doctrine\DBAL\Types\Type;
 use Doctrine\ORM\EntityManagerInterface;

 class SystemImporter extends BaseImporter


Remove extra blank lines in this file.

jekuaitk · 2025-01-02T09:54:29Z

+//    /**
+//     * @var \DateTime
+//     * @ORM\Column(type="datetime", nullable=true)
+//     */
+


Suggested change

// /**

// * @var \DateTime

// * @ORM\Column(type="datetime", nullable=true)

// */

jekuaitk · 2025-01-02T09:54:43Z

+
+

Suggested change

jekuaitk · 2025-01-02T09:56:37Z

+{#                <a href="{{ easyadmin_path('Answer', 'edit', { id: answer.id }) }}">#}
+
+


Suggested change

{# <a href="{{ easyadmin_path('Answer', 'edit', { id: answer.id }) }}">#}

jekuaitk · 2025-01-02T09:57:14Z

 {% block main %}
+
+
+
  <div class="container-fluid">
+
+
    <h1>{{ 'export.headline' | trans }}</h1>


Suggested change

{% block main %}

<div class="container-fluid">

<h1>{{ 'export.headline' | trans }}</h1>

{% block main %}

<div class="container-fluid">

<h1>{{ 'export.headline' | trans }}</h1>

@Mr-Martin-Kristiansen, consider adding https://github.com/VincentLanglet/Twig-CS-Fixer as a development dependency to clean up the Twig templates. We use that tool in several projects, e.g. https://github.com/itk-dev/aapodwalk_api/ (see also https://github.com/search?q=org%3Aitk-dev%20vincentlanglet%2Ftwig-cs-fixer&type=code).

…dded an error catch to controllers

Onkel-Martin added 9 commits March 3, 2023 15:13

updated readme open statment

5237778

README updated for composer v.2, updated upload command command

7b24c62

made a minor change

df258a6

ITSTYR-81 / 1. Installed new symfony project / copied new docker file…

4e988a0

…s over / FIRST COMMIT

testing mermaid on git

4483629

added a Flowchart over the entities

0f5dbe3

updatet readme with flowchart text

f4675dd

updatet readme with flowchart text 2

b6e24d5

ITSTYR-81 added makerbundle

39303fa

Onkel-Martin requested a review from rimi-itk March 9, 2023 12:52

Onkel-Martin added 20 commits March 13, 2023 10:10

added entity Importrun with proberties

77d44fa

ITSTYR-81 added all Entities, no attributes besides id added

ead0cb4

ITSTYR-81 updated src/Entity/SelfServiceAvailableFromItem

fa557ee

ITSTYR-81 - Added all atributes to Themecategory, and ManytoMany arra…

0318dc7

…ys in Category, Theme

ITSTYR-81 - Added gedmo/doctrine-extensions

a4366e2

ITSTYR-81 updated entity Theme

5e37f06

ITSTYR-81 updated entity Category and Theme

74cc768

ITSTYR-81_ updated with validator package

d8d3844

ITSTYR-81 Updated Entity Category

fded5f2

ITSTYR-81 Updated Entity Question

95e8ddd

ITSTYR-81 Updated Entity Answer

2bdb6b0

ITSTYR-81 Updated Entity Report

219208f

ITSTYR-81 / added Updated Entity Report

4fc5aac

Updated Entity System

c760075

ITSTYR-81 / added Entity Group and User

d0456cf

added migrations

e4e13ff

ITSTYR-81 / updated some of the older migrations, because ive got an …

b8d2c85

…error

ITSTYR-81 updated env name, and added a .gitignore folder which needs…

df34752

… to be deleted later

ITSTYR-81 Updated Entity Answer with smileyType

4fd7a51

ITSTYR-81 Added stoff-bundle, and fresh bundle for TimeStamble entity…

c1aa490

… and SmileyType

Mr-Martin-Kristiansen added 15 commits December 2, 2024 12:09

right now

6718a5f

updated Routes, Updated LoginController, updated config - the site is…

1e84179

… now checking auth

trying to figure out keys in answer_show.html.twig

f1396e3

updated twig variable

179d3d9

updated system controller

5b9bb82

added AnswerController

854b020

updated templates/easy_admin_overrides/answers_show.html.twig

2475b81

updated smileys

2d91951

updated Dashboard system, and added content to Dashboard repport, and…

c83b00a

… updated the smiley twig template

updated styling, and RepportCrudController

5b6c4f5

added Report and System

e42de90

aded documentation/HowToUse.md, updated twig files to import with !@e…

a8ed2bc

…asyadmin... since the documentation states infinit loop

added

0fa4ac5

filter is updated and working

d5142f9

added Documentation, and updated some minor nbugs

4f7bff9

jekuaitk requested changes Jan 2, 2025

View reviewed changes

Mr-Martin-Kristiansen added 12 commits January 2, 2025 13:08

added datafixtures, and removed from .gitignore

22ab2df

added coding standard for migrations

6bf6528

updated coding standard

cb98313

coding stadard in Repository

c9039d4

added coding standard to entity

384a7f4

coding standard FORM

a460f64

new coding standards

ea851b7

added coding standards, removed outcommented code from controllers, a…

4942383

…dded an error catch to controllers

added null value to ArchivableEntity, removed verification-email-bundle

3a8e873

updated styling

2d2182e

changed route for smuileys

5c050e5

coding standards

a840769

cableman merged commit c75bcb2 into develop Jan 13, 2025

cableman deleted the feature/ITSTYR-81_symfony6upgrade branch January 13, 2025 08:47

		{# <a href="{{ easyadmin_path('Answer', 'edit', { id: answer.id }) }}">#}

Conversation

Onkel-Martin commented Mar 9, 2023

Uh oh!

jekuaitk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants