Conversation
…rs with sub_filters
…gs render assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds per-trigger sub-settings for fine-grained control over when Smart Capture fires, and wires Connection Monitor packet loss events into the engine as a 5th trigger source.
Shared DOCSIS Utility
QAM_ORDER+qam_rank()fromevent_detector.pytoapp/docsis_utils.pyprev_rank/current_rankin modulation change event detailsSub-Filter Architecture
Triggerdataclass extended withsub_filter: Callablefieldapp/smart_capture/sub_filters.pyusing qualifying-subset logic (any matching change triggers)Per-Trigger Sub-Settings
Connection Monitor Wiring
set_smart_capture()method on CM Collector for post-construction injectionsave_events_with_ids()for event ID annotationSettings UI
i18n
Closes #245
Test plan