Add CI workflow for linting artifacts #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophokles73
force-pushed
the
add_shellcheck
branch
2 times, most recently
from
dc64dd8 to
80bb375
Compare
Collaborator
Author
|
@kaklakariada Which ShellCheck Action can we use? |
Contributor
|
I would prefer not to use an action. Shellcheck is already installed, please create a small script that executes it and call it from a workflow. This way it's easy to run the same check locally. If you prefer I can take over this task, no problem! |
Run ShellCheck on workspace files.
sophokles73
force-pushed
the
add_shellcheck
branch
from
80bb375 to
0fc504b
Compare
Collaborator
Author
|
@kaklakariada I have replaced the Action with running shellscript directly ... |
kaklakariada
approved these changes
Aug 21, 2024
Contributor
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run ShellCheck on workspace files.
This addresses #2
Closes #2