Feature/352 tag parsing in xml documents#532
Merged
Merged
Conversation
…porters to support the same file suffix.
…ocuments' into feature/352_tag-parsing-in-xml-documents
kaklakariada
approved these changes
Jun 1, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced priorities in importer factories to allow having more than one supporting a file extension and still getting back a single result in a controlled manner.
This allowed me to introduce
.xmlin the tag importer. The tag importer has a lower priority than the SpecObject importer. Since the SpecObject importer peeks into the XML files and refuses to support them when the expected header is missing, the tag importer gets its chance on non-SpecObject XML.@g-psantos , that should do the trick for annotating regular XML files with coverage. I know, this one has been long in the making, but I needed to figure out a way that could be done with minimal changes.
Closes #352.