Skip to content

Conversation

@sarahsga
Copy link
Contributor

@sarahsga sarahsga commented Apr 4, 2017

This PR resolves #11
notifier

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 888a9bc on sarahsga:feat/color-change into ** on dominique-mueller:develop**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 87ba714 on sarahsga:feat/color-change into ** on dominique-mueller:develop**.

Copy link
Owner

@itsdevdom itsdevdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis still shows SASS linter issues, could you write the colors as uppercase HEX to fix them?

Otherwhise it looks great! Thanks for your PR!

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e3bca7d on sarahsga:feat/color-change into ** on dominique-mueller:develop**.

@itsdevdom
Copy link
Owner

Awesome! Thanks again for contributing 👍

@itsdevdom itsdevdom merged commit 18eb1d2 into itsdevdom:develop Apr 4, 2017
@sarahsga
Copy link
Contributor Author

sarahsga commented Apr 4, 2017

I guess the docs gif needs to be updated too. Will do that

@itsdevdom
Copy link
Owner

If you find the time, that'll be awesome.

@itsdevdom
Copy link
Owner

I've used ScreenToGif to create it, and exported it with all size optimizations possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change color of success notification to green

3 participants