Skip to content

Conversation

@tatounee
Copy link
Contributor

@tatounee tatounee commented Nov 6, 2025

In respect to the Fuchsia convention used by xflags (and the behavior of all programs created in the world), the flags -f and --fullscreen shouldn't take an argument, but their presence alone should be enough to activate the option.

This PR implement this change.

Now, its presence alone is enough to activate the full-screen option.
@itsjunetime
Copy link
Owner

Huh, I didn't really realize that you could just omit the : bool for flags with xflags. Thanks for changing this, and I suppose I should change the r_to_l flag as well to match this.

@itsjunetime itsjunetime merged commit 6b37976 into itsjunetime:main Nov 7, 2025
1 check passed
@itsjunetime
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants