Skip to content

readerjs </script> breakout #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nleush merged 1 commit into from
May 21, 2026
Merged

readerjs </script> breakout #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions modules/api/views.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,18 @@ export default function(app) {

var htmlArray = (html || "").match(/.{1,8191}/g) || "";

// Emitted raw inside a <script> in readerjs.ejs. JSON.stringify does
// not escape "<", so a value containing "</script>" would break out of
// the script element (XSS). Escape "<" to its < JS escape, which
// is inert in HTML but decodes back to "<" in JS.
function jsonForScript(value) {
return JSON.stringify(value).replace(/</g, '\\u003c');
}

var context = {
embedCode: JSON.stringify(htmlArray),
embedCode: jsonForScript(htmlArray),
widgetId: JSON.stringify(1),
uri: JSON.stringify(uri)
uri: jsonForScript(uri)
};

res.renderCached("readerjs.ejs", context, {
Expand Down
Loading