Merged
Conversation
liuyueyi
reviewed
Feb 18, 2025
Collaborator
liuyueyi
left a comment
liuyueyi
left a comment
There was a problem hiding this comment.
这个地方不是问题哈，借助的是Closeable接口的try finally机制
| }, img.getUrl()); | ||
| } | ||
| // 等待所有图片转存完成 | ||
| bridge.allExecuted(); |
Collaborator
There was a problem hiding this comment.
这个 try 语法，会在close方法中自动执行 allExecuted 方法; 关于 AsyncUtil的异步工具类的封装方法的实现全流程，可以参照系列博文：- trace-watch-dog | 一灰灰的站点
Collaborator
There was a problem hiding this comment.
有问题的地方在初始化这里，markOver 的初始值应该是 false 而不是 true，期待你的更正
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
在原本的代码中，异步计算图像新路径并没有等待任务完成，而是直接进行下一步操作，导致imgReplaceMap其实为空。
加入等待异步完成语句前测试结果：
加入等待异步完成语句后测试结果：