Repository navigation
Replies: 2 comments
|
Thanks for merging #57 and #60, and for the detailed reviews. I'm working through the requested changes on #58, #61 and #62 and rebasing #59; I'll reply on each PR when it's updated. There's one new PR, which came out of running the integrations on a real instance: #65, which fixes
I verified it against a real Postgres 17. The old insert pattern deadlocked on about 670 of 800 concurrent statements, the new one on none, and issue counts stayed exact under concurrency. It's been running on my instance with zero deadlocks since. Details are in the PR. |
|
Update on the open PRs. Every review comment so far has been addressed, and I replied on each PR with what changed. Everything is rebased on current master, and each PR is mergeable. Integrations
Fixes and shared pieces
Suggested order: #67 and #65 first, then the integrations in any order. I'm happy to adjust anything you'd rather have differently. |
Uh oh!
There was an error while loading. Please reload this page.
Hi! I've been running Logarr on my NAS and built five integrations from the "coming soon" list, plus a fix for *arr file ingestion. They're open as PRs and ready for review. This discussion gives an overview in one place, so you can see how they fit together.
provider-arrused by #60/#61.bazarr.logseerr-*.log(also covers Overseerr and Jellyseerr, which share the same API)provider-arr(stacked on #57)provider-arr, labelled best-effort since Readarr was retired upstream (stacked on #57)Suggested merge order: #57 first, because #60 and #61 build on it. The others are independent. They all touch the same registration and README/compose lines, so whichever goes second needs a trivial rebase, which I'm happy to do.
Design points worth your opinion:
servers.usernamecolumn (migration0010) and two optionalProviderCapabilitiesflags,supportsUsernameandapiKeyOptional, so that username/password auth isn't hard-coded to one provider.overseerrandjellyseerr"coming soon" entries with oneseerrentry, which search still finds under both names.[id] Failed to get …logging, and fetch-mocked specs. Each PR has around 80–160 unit tests, andbuild/lint/typecheck/testpass.I've been running all of them merged together on my own instance, and #57 has already been through real logs. I'm happy to split, rename or rework anything. If you'd prefer a different order or scope, let me know.
All reactions