Some JAR SPIGET plugins are being decompressed

[JAHMCR]

Describe the problem

When trying to download some plugins using SPIGET they are being decompressed instead of just copying to the plugins folder.

It happened with the following plugins:

DeluxeMenus (11734)
LuckPerms (28140)
PlaceholderAPI (6245)
SkinsRestorer (2124)
ViaVersion (19254)
ViaBackwards (27448)

Container definition

No response

Container logs

Server  | [init] Downloading resource 6245 ...
Server  | [init] Extracting contents of resource 6245 into plugins
Server  | [init] Downloading resource 11734 ...
Server  | [init] Extracting contents of resource 11734 into plugins
Server  | replace /data/plugins/META-INF/MANIFEST.MF? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL
Server  | (EOF or read error, treating as "[N]one" ...)
Server  | [init] Downloading resource 27448 ...
Server  | [init] Extracting contents of resource 27448 into plugins
Server  | replace /data/plugins/META-INF/MANIFEST.MF? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL
Server  | (EOF or read error, treating as "[N]one" ...)

[itzg]

Thanks for reporting this!

Introduced by #1413

[itzg]

The latest images should now fix this issue.

[JAHMCR]

Thank you very much @itzg! I just pulled the image and it works!

[JAHMCR]

But now I'm now getting this error, is it related or should I create a different issue?

[init] Getting plugins via Spiget [init] Downloading resource 2124 ... [mc-image-helper] 02:49:10.485 ERROR : 'get' command failed: Unexpected content type 'application/octet-stream', expected any of [application/zip, application/java-archive] [init] ERROR: failed to download resource '2124' from https://api.spiget.org/v2/resources/2124/download [init] Visit https://github.com/SkinsRestorer/SkinsRestorerX/releases/download/14.1.13/SkinsRestorer.jar to pre-download the resource [init] instead of using SPIGET_RESOURCES

[itzg]

I'm glad the fix got you past the first part.

I guess I'll have to relax the content type since the mod authors are very inconsistent with their published artifacts 😞

[JAHMCR]

Thanks @itzg, hopefully you figure it out!

[itzg]

You reformatted the output and it hid the instructions it was telling you. As originally formatted:

[mc-image-helper] 00:39:33.022 ERROR : 'get' command failed: Unexpected content type 'application/octet-stream', expected any of [application/zip, application/java-archive]
[init] ERROR: failed to download resource '2124' from https://api.spiget.org/v2/resources/2124/download
[init]        Visit https://github.com/SkinsRestorer/SkinsRestorerX/releases/download/14.1.13/SkinsRestorer.jar to pre-download the resource
[init]        instead of using SPIGET_RESOURCES

So you need to

Visit https://github.com/SkinsRestorer/SkinsRestorerX/releases/download/14.1.13/SkinsRestorer.jar to pre-download the resource instead of using SPIGET_RESOURCES