I thought it should work

[boyphongsakorn]

Enhancement Type

Improve an existing feature

Describe the enhancement

after i PR this #1792
I thought it should work, so i didn't try.

docker-minecraft-server/scripts/start-spiget

Lines 124 to 135 in 5e25532

	if [[ ${SPIGET_RESOURCES} ]]; then
	if isTrue "${REMOVE_OLD_MODS:-false}"; then
	removeOldMods /data/plugins
	REMOVE_OLD_MODS=false
	fi
	log "Getting plugins via Spiget"
	IFS=',' read -r -a resources <<<"${SPIGET_RESOURCES}"
	for resource in "${resources[@]}"; do
	getResourceFromSpiget "${resource}"
	done
	fi

but today i try and is not redownload
I wonder after removeOldMods (Line 126), is that set REMOVE_OLD_MODS back to false (Line 127), so that is not work.

[itzg]

Please set DEBUG=true and DEBUG_HELPER=true on your container and provide those logs. The inclusion here should have caused the version files to removed in the first place:

docker-minecraft-server/scripts/start-spiget

Line 11 in 5e25532

: "${REMOVE_OLD_MODS_INCLUDE:=*.jar,*-version.json}"

[boyphongsakorn]

2022-10-25T13:48:27.897423762Z + removeOldMods /data/plugins
2022-10-25T13:48:27.897436432Z + '[' -d /data/plugins ']'
2022-10-25T13:48:27.897459021Z + log 'Removing old mods including:*.jar excluding:_'

🤔 hmmm something wrong?

[boyphongsakorn]

ok i forget to remove REMOVE_OLD_MODS_INCLUDE env set 😂