Skip to content

Add Pufferfish support #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2022
Merged

Add Pufferfish support #1255

merged 2 commits into from
Jan 6, 2022

Conversation

@bram-pkg
Copy link
Contributor

@bram-pkg bram-pkg commented Jan 5, 2022 •
edited
Loading

I hope I didn't forget anything.

Tested it locally with this docker-compose and it all seems to work:

version: '3'

services:
  mc:
    build: .
    environment:
      EULA: true
      TYPE: 'PUFFERFISH'
      VERSION: 'LATEST'
      PUFFERFISH_BUILD: '29'

I've also opened an issue on the Pufferfish repo to maybe clean up the .jar name a bit.

Closes #1226

@bram-pkg bram-pkg mentioned this pull request Jan 6, 2022
Closed
itzg
itzg requested changes Jan 6, 2022
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just the minor change, which is originally my fault. With that it'll be good to merge.

@bram-pkg
Copy link
Contributor Author

bram-pkg commented Jan 6, 2022

Changed curl to get now, also modified the Airplane script. Hope you don't mind a small "out of scope" fix for the sake of consistency.

itzg
itzg approved these changes Jan 6, 2022
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow up

@itzg
Copy link
Owner

itzg commented Jan 6, 2022

Changed curl to get now, also modified the Airplane script. Hope you don't mind a small "out of scope" fix for the sake of consistency.

That's excellent

@itzg itzg merged commit 967d515 into itzg:master Jan 6, 2022
@bram-pkg bram-pkg deleted the add-pufferfish branch January 6, 2022 12:50
@bram-pkg
Copy link
Contributor Author

bram-pkg commented Jan 6, 2022

No problem! Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itzg itzg itzg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pufferfish support

2 participants

@bram-pkg @itzg