fix: Set default MOTD if unset #1265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
requested changes
Jan 10, 2022
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks for helping out on this. You had the right line and my original intent was correct, just a typo on the -v usage.
Owner
|
Sorry for committing my own suggestion. Wanted to get this merged and published ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1261
-v "$MOTD"is used to check if a environment variable is unset, and returns 0 (FALSE) if the value is set.Thank you to @Stealthii for identifying this issue.