Adding forge api calls for project ids #1275
Conversation
shotah
commented
Jan 13, 2022
shotah
commented
- Adding setup script to take project ids and download them from forge.
- Broke out testing into separate folders so Setup Only can be called separately or together
- Added CI and Discord workflows
…e just setuponly tests, added CI and Discord workflows
|
@itzg The code is passing now in CI. Looks like the PR is still failing due to using Github secrets. |
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Great contribution! Just a couple of minor things and this is good to merge.
.github/workflows/discord.yml
Outdated
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ["ContinuousIntegration", "PullRequest" ] |
There was a problem hiding this comment.
...and then can
| workflows: ["ContinuousIntegration", "PullRequest" ] | |
| workflows: ["Build and publish multiarch", "PullRequest" ] |
There was a problem hiding this comment.
definitely will add build and publish. Will wait for your comment on CI first to remove ci.
There was a problem hiding this comment.
Did you want "Build and Publish" on there as well?
There was a problem hiding this comment.
Not sure if this is what you are waiting on, but they were already added. Let me know.
workflows: ["ContinuousIntegration", "PullRequest", "Build and Publish", "Build and publish multiarch" ]
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
Co-authored-by: Geoff Bourne <itzgeoff@gmail.com>
…cord, using vanilla_version inplace of version
|
Run on lastest changes: |
.github/workflows/discord.yml
Outdated
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ["ContinuousIntegration", "PullRequest" ] |
| timeout-minutes: 5 | ||
| steps: | ||
| - name: notify | ||
| if: github.event.label.name == 'enhancement' || github.event.label.name == 'bug' |
There was a problem hiding this comment.
Oh...I think the example I had found was looking at event.issue.labels, but instead it looks like what you have used is exactly what I was wanting in the first place in pr.yml.
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Sorry that I really dragged out the review on this one. Great addition!
2 participants
