fix(purpur): apply log4j mitigations specific to Purpur #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotah
reviewed
Jan 17, 2022
| case ${TYPE} in | ||
| SPIGOT|BUKKIT|PAPER|MAGMA) | ||
| case ${FAMILY} in | ||
| SPIGOT|HYBRID) |
Contributor
There was a problem hiding this comment.
excuse my ignorance, but where is HYBRID coming from?
Owner
Author
There was a problem hiding this comment.
It's a convention I had to make up for grouping all the various server types. Here's one example
Contributor
There was a problem hiding this comment.
I see it now. This looks good to me if you've tested it. 👍
Owner
Author
There was a problem hiding this comment.
Thanks! I'll go ahead and merge it since I had already forgotten about this PR 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1274