Fix loading world from compressed tar archives #1304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MIME type detected for a tar file depends on the compression scheme in use; match any of the schemes supported by mc-backup, as well as uncompressed tar files. .tar.zst archives require the zstd package; add it to the Dockerfile. The existing test labelled as tgz actually contained just an uncompressed tar file padded to 10KiB with zeroes. I assume this was unintended (tar won't automatically compress according to the file extension unless you pass -a). Rename that test to "tar", and add equivalent tests for .tar.gz, .tar.bz2, and .tar.zst (the three types of compression supported by mc-backup).
itzg
approved these changes
Jan 25, 2022
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Thanks! Yes, I can now picture myself doing only tar cf to create that test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MIME type detected for a tar file depends on the compression scheme in use; match any of the schemes supported by mc-backup, as well as uncompressed tar files.
.tar.zstarchives require thezstdpackage; add it to the Dockerfile.The existing test labelled as
tgzactually contained just an uncompressed tar file padded to 10KiB with zeroes. I assume this was unintended (tar won't automatically compress according to the file extension unless you pass -a). Rename that test to.tar, and add equivalent tests for.tar.gz,.tar.bz2, and.tar.zst(the three types of compression supported by mc-backup).