Add GameType filter, and add ForgeAPI Verify Files to validate Mod Downloads #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng variable on line 197
shotah
commented
Feb 6, 2022
shotah
commented
Feb 6, 2022
Contributor
Author
|
@itzg here's the PR. |
itzg
reviewed
Feb 6, 2022
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Just the unset change I think is needed
… with defaulting to false and server types
shotah
changed the title
Adding Itzg suggestion to remove $ from unset.
Contributor
Author
|
@itzg Fixed Unset, also included Gametype. It was a small code change, testing on the other hand was a bit more verbose. I wonder if there is a way to be more verbose in the docker file about what is being tested. I just added comments for now to explain what is being tested. |
…download, updated readme
…ly in an if statement
Owner
Specifically do you mean the docker compose file in each test directory? |
itzg
approved these changes
Feb 9, 2022
| # Stage contents so that the correct subdirectory can be picked off | ||
| mkdir -p /tmp/world-data | ||
| if ! extract "$WORLD" /tmp/world-data; then | ||
| log "ERROR extracting world from $WORLD" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.