build: add alpine support to matrix builds #1349
Conversation
|
|
||
| distro=$(cat /etc/os-release | grep -E "^ID=" | cut -d= -f2 | sed -e 's/"//g') | ||
|
|
||
| "$(dirname "$0")/${distro}/$1".sh No newline at end of file |
| } | ||
|
|
||
| function getDistro() { | ||
| cat /etc/os-release | grep -E "^ID=" | cut -d= -f2 | sed -e 's/"//g' |
There was a problem hiding this comment.
Nice I need to learn to cat out as a return in bash. My bash could use some improvement! :)
There was a problem hiding this comment.
That particular one apparently came from Github Copilot via a recent PR
| fi | ||
|
|
||
| docker-compose down -v --remove-orphans | ||
| docker-compose down -v --remove-orphans > /dev/null |
There was a problem hiding this comment.
Do we need the -v if we are just outputting to Null anyways? Not seeing -v referenced, but pretty sure it's short for --verbose. https://docs.docker.com/compose/reference/
There was a problem hiding this comment.
It's for removing any names volumes
There was a problem hiding this comment.
Doh, I think I remember that now. :) Glad you caught it!
|
@shotah Thanks for taking a look at the PR BTW |
Hey I'm excited for alpine to be reintroduced. This does updated it for Java17 and Latest correct? |
|
Yep, it became super easy to add back an alpine variant for Java 17. It's also going to make it much easier to add GraalVM, which has a base image on CentOS. |
No description provided.