Skip to content

fix #1544 #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2022
Merged

fix #1544 #1608

merged 1 commit into from
Jul 16, 2022

Conversation

@caycehouse
Copy link
Contributor

@caycehouse caycehouse commented Jul 16, 2022

This should fix #1544 by picking the directory path closest to $base_dir, rather than the first match.

itzg
itzg approved these changes Jul 16, 2022
View reviewed changes
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@itzg itzg merged commit 16a958d into itzg:master Jul 16, 2022
@itzg itzg mentioned this pull request Jul 17, 2022
Closed
@caycehouse caycehouse mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itzg itzg itzg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installing Forge server from generic pack with kubejs fails

2 participants

@caycehouse @itzg