Fix typo in deployAutoCF-Script

[denizkoekden]

You made a little typo in your last commit which broke the container with existing Compose-Files. This fixes it.

[itzg]

That's not a typo. Please provide an example that doesn't work.

[denizkoekden]

This worked fine till the yesterday :/
version: "3.9" services: mc: image: itzg/minecraft-server:java17 container_name: "mc" command: ${COMMAND_PARAMS} ports: - "20000:25565/tcp" - "20030:25575/tcp" - "20000:25565/udp" - "20030:25575/udp" - "20020:25585/udp" environment: TYPE: "AUTO_CURSEFORGE" OVERRIDE_SERVER_PROPERTIES: "false" EULA: "TRUE" CF_SLUG: "better-mc-new" CF_FILE_ID: 4404474 GUI: "FALSE" INIT_MEMORY: "1G" MAX_MEMORY: "4G" USE_AIKAR_FLAGS: "true" JVM_XX_OPTS: "-XX:+UseG1GC" CF_EXCLUDE_INCLUDE_FILE: "https://mypage.com/myownfile.json" CF_FORCE_SYNCHRONIZE: "true" tty: true stdin_open: true restart: "no" volumes: - ./minecraft-data:/data - ./modpacks:/modpacks:ro

[itzg]

FYI, info on that syntax.

Please clarify what is not working. Have you run with DEBUG: "true" to investigate the invocation of mc-image-helper?

[itzg]

I might have reproduced it, but it seems to be an issue in mc-image-helper, not that variable initialization.

[itzg]

BTW, thanks for reporting the issue and pro-actively trying to fix it!

[itzg]

Fix is on the way itzg/mc-image-helper#172

I need more unit tests over there 🤦‍♂️

[denizkoekden]

Yes no problem. This seemed to be the most obvious thing to me. But seeing the commit in mc-image-helper that makes more sense. Will try it as soon as the image is deployed on docker hub. Thanks!

[itzg]

To give some context, that was one of the rare times that syntax is useful since I needed to differentiate an unset value vs a value set with an empty string to allow for disabling the default file usage.

[itzg]

Image build is in progress: https://github.com/itzg/docker-minecraft-server/actions/runs/4479470997

[denizkoekden]

Its working now btw :) Thanks