possible solution to deploy to both dockerhub and ghcr

[camalot]

I am not able to test this AFAIK because of permissions and such, but this should log in to both dockerhub and ghcr, and add image tags for both dockerhub and ghcr.

Closes #1444 and #2009

[itzg]

The changes look right to me. I'll try to lookup how I did my initial testing of the image publishing 😀.

[itzg]

...oh, I remember now. The build triggers inlcude branches that start with test/.

[itzg]

As far as you testing it, I think it'll work for a non-PR'ed branch that starts with test/ as long as you have the Docker hub credentials declared in your repo actions secrets.

[camalot]

I will see if i can get it to test when I take lunch.

[camalot]

i see in the build-multiarch a reference to MODS_FORGEAPI_KEY. can you point me to where I can request a key? I am creating a test/ branch to make sure this all works.

[itzg]

That's one in the same as CF_API_KEY just it's from an older contributes feature. (I need to deprecate away that feature at some point.)

It should actually be optional for the build and didn't remember that I even had that set in my repo secrets 😀

[camalot]

Ok, i was going to try my CF Key. thanks.

[itzg]

...and now that I rediscovered that, makes me realize I could be re-enabling the build time test for auto CurseForge by re-mapping that variable

[itzg]

If you want to include that with your PR it would be a copy of this line

docker-minecraft-server/.github/workflows/build-multiarch.yml

Line 152 in 0d5e44a

MODS_FORGEAPI_KEY: ${{ secrets.MODS_FORGEAPI_KEY }}

but with CF_API_KEY being the resulting variable.

[camalot]

ive got a test/ branch running now with those changes, since this PR is open on the non-test branch, if it is successful, I will merge those changes back in to this branch, and will reference the test branch action runs.

[camalot]

https://github.com/camalot/docker-minecraft-server/actions/runs/4576294508 current run

[camalot]

Login for GHCR was successful for all platforms. as was the build. the build and push was also successful, but doesn't actually push (so it isn't fully tested with the github.token) since it isn't running from a PR to master.

[camalot]

I have a feeling that using github.token isn't going to have access to push to GHCR. I haven't tested this feeling yet though.

EDIT:

I take that back. i have a repo that pushes to GHCR and uses github.token

[itzg]

I'm sorry that I forgot about this PR. Later today I'll either do a quick test branch build or just merge and tweak configs from there if needed.

[itzg]

Pushed some fixes to the build to handle test/* branches. Apparently I broke it was back when I switched to matrix builds.

[camalot]

I see that the push to ghcr.io is failing with a 500. i may modify the job that pushes to have it push to my docker hub and ghcr. see if i can reproduce it.

[camalot]

I got an error, but mine was a 403 forbidden. I am trying now to change the "actions settings" on my fork to allow read/write, to see if that allows the push.

[itzg]

That would be great. Using the github.token way it was mostly 500's:

https://github.com/itzg/docker-minecraft-server/actions/runs/4600691357

Using secrets.GITHUB_TOKEN, which I just pushed, it was a mix of success and 403's

https://github.com/itzg/docker-minecraft-server/actions/runs/4603497390/jobs/8133557812

I'm suspecting there is a rate limit on GHCR publish operations, where 14 concurrent ones probably exceeds that.

[camalot]

https://github.com/camalot/docker-minecraft-server/pkgs/container/minecraft-server

I changed the action settings to read/write and it pushed to ghcr for my fork, and my docker hub

[camalot]

https://github.com/camalot/docker-minecraft-server/tree/test/ghcr-publish

this is the branch that pushed.

[camalot]

Obviously i had to change the build-publish workflow to push to on a less restrictive criteria. but that is the only thing that should have been changed compared to what i pushed to this branch.

[itzg]

i had to change the build-publish workflow to push to on a less restrictive criteria

Hmm, I had the workflow settings like you screenshot'ed above, so I'm wondering what you mean by these workflow changes?

The mix of success and 403's (and 500s) was very odd though. It's like the permissions are right, but something sporadically fails.

[camalot]

This is what i changed in my test/ branch to force it to push for me. everything else in my branch should be in-line with the rest of the changes in this PR.

Actually, im not 100% that I pulled in all the changes you pushed to this branch. Let me do that and run it again.

[camalot]

my test/ghcr-publish branch published successfully after making sure I had all your changes. the only change i made after that was changing back to use github.token vs secrets.GITHUB_TOKEN

[itzg]

Can you point me to the latest build that went through for you? I'll put my test branch back to github.token and see how it is now.

[camalot]

the run https://github.com/camalot/docker-minecraft-server/actions/runs/4613328275

the branch https://github.com/camalot/docker-minecraft-server/tree/test/ghcr-publish