Skip to content

possible solution to deploy to both dockerhub and ghcr #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 9, 2023
Merged

possible solution to deploy to both dockerhub and ghcr #2051

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
858de8c
possible solution to deploy to both dockerhub and ghcr #1444 #2009
camalot Mar 30, 2023
c719bf1
Merge branch 'master' into ghcr-publish
camalot Mar 31, 2023
cac2ceb
added CF_API_KEY to re-enable build time test for auto curseforge
camalot Mar 31, 2023
a1ada90
Merge branch 'master' into ghcr-publish
camalot Mar 31, 2023
ec1726a
Corrected image builds for test branches
itzg Apr 3, 2023
9ccc980
Scoped tags type=raw
itzg Apr 3, 2023
4e26654
Enable image push for test branches
itzg Apr 3, 2023
e93c04b
Use documented login-action config
itzg Apr 4, 2023
63447a9
Merge branch 'itzg:master' into ghcr-publish
camalot Apr 4, 2023
2bad502
Try github.token again
itzg Apr 8, 2023
4f4c33a
Merge remote-tracking branch 'camalot/ghcr-publish' into ghcr-publish
itzg Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/build-multiarch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,16 @@ jobs:
# then the use of ${{ github.repository_owner }} will need to be replaced.
images: |
${{ github.repository_owner }}/minecraft-server
ghcr.io/${{ github.repository_owner }}/minecraft-server
tags: |
type=ref,event=tag,enable=${{ matrix.variant == 'java17' }}
type=ref,event=tag,enable=${{ matrix.variant == 'java17' && github.ref == 'master' }}
type=ref,event=tag,suffix=-${{ matrix.variant }}
type=raw,value=${{ matrix.variant }}
type=ref,event=branch,suffix=-${{ matrix.variant }},enable=${{ github.ref != 'master' }}
type=raw,value=${{ matrix.variant }},enable=${{ github.ref == 'master' }}
# NOTE this identifies which variant will be published as "latest", which isn't
# necessarily the newest version of Java
flavor: |
latest=${{ matrix.variant == 'java17' }}
latest=${{ matrix.variant == 'java17' && github.ref == 'master' }}
labels: |
org.opencontainers.image.authors=Geoff Bourne <itzgeoff@gmail.com>

Expand Down Expand Up @@ -150,6 +152,7 @@ jobs:
MINECRAFT_VERSION: ${{ matrix.mcVersion }}
VARIANT: ${{ matrix.variant }}
MODS_FORGEAPI_KEY: ${{ secrets.MODS_FORGEAPI_KEY }}
CF_API_KEY: ${{ secrets.MODS_FORGEAPI_KEY }}
run: |
tests/test.sh

Expand All @@ -160,6 +163,14 @@ jobs:
username: ${{ secrets.DOCKER_USER }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Login to GHCR
uses: docker/login-action@v2
if: env.HAS_IMAGE_REPO_ACCESS
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ github.token }}

- name: Build and push
uses: docker/build-push-action@v3.3.0
if: github.actor == github.repository_owner
Expand All @@ -168,7 +179,8 @@ jobs:
push: >
${{
github.ref_type == 'tag'
|| github.ref_name == 'master'
|| github.ref_name == 'master'
|| startsWith(github.ref_name, 'test/')
|| ( github.event_name == 'pull_request'
&& env.HAS_IMAGE_REPO_ACCESS
&& contains(github.event.pull_request.labels.*.name, 'ci/push-image')
Expand Down