Pass EXTRA_ARGS to run.sh (fixes #2714)

[robinbraemer]

No description provided.

[itzg]

Thanks!

[robinbraemer]

I'm not a bash pro so we will probably want to specifically want the variables to expand to args the same way as done in finalArgs.

Edit:

In my testing it works fine in any case: EXTRA_ARGS can be empty; EXTRA_ARGS can contain --universe /data/worlds; haven't tested if EXTRA_ARGS with more flags works, but I assume so

[robinbraemer]

Confirming the added DEBUG_EXEC also prints as expected

[init] Using Forge supplied run.sh script...
+ exec mc-server-runner --stop-duration 60s --shell bash run.sh '--universe ./worlds/'

[robinbraemer]

Warning: looks like there is still an issue: I just tried deploying it in k8s.

[minecraft/Main]: Failed to start the minecraft server
joptsimple.UnrecognizedOptionException: universe /data/worlds is not a recognized option

[itzg]

I'm glad to hear using multiple args seems to have worked. That would have been my only doubt also.

[robinbraemer]

Trying out "${EXTRA_ARGS[@]}" would behave...

[itzg]

and just saw your follow up. Removing the double quotes around the car should help it here.

Sorry if I merged your PR too soon. Will need a new one for the tweak.

[robinbraemer]

Better reopen this PR if possible, trying to fix it here. or well i'll make a new pr

[itzg]

Trying out "${EXTRA_ARGS[@]}" would behave...

I don't think adding the @ will work since it's a string variable and not an array.

[itzg]

Notice it's not quoted when added here

docker-minecraft-server/scripts/start-finalExec

Line 323 in 3d2b88e

"$@" $EXTRA_ARGS

[itzg]

We'll need a new PR since merged PRs can't be re-opened.