Skip to content

Pass EXTRA_ARGS to run.sh (fixes #2714) #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Pass EXTRA_ARGS to run.sh (fixes #2714) #2715

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4557711
Pass EXTRA_ARGS to run.sh (fixes #2714)
robinbraemer Mar 13, 2024
9645390
Add print DEBUG_EXEC in run.sh case too
robinbraemer Mar 13, 2024
f8c420d
fix(try): Pass EXTRA_ARGS as arguments correctly
robinbraemer Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/start-finalExec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,10 @@ elif [[ $SERVER =~ run.sh ]]; then
echo "SETUP_ONLY: bash ${SERVER}"
exit
fi
exec mc-server-runner "${mcServerRunnerArgs[@]}" --shell bash "${SERVER}"
if isTrue "${DEBUG_EXEC}"; then
set -x
fi
exec mc-server-runner "${mcServerRunnerArgs[@]}" --shell bash "${SERVER}" "${EXTRA_ARGS}"
Copy link
Owner

@itzg itzg Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and just saw your follow up. Removing the double quotes around the car should help it here.

Sorry if I merged your PR too soon. Will need a new one for the tweak.

else
# If we have a bootstrap.txt file... feed that in to the server stdin
if [ -f /data/bootstrap.txt ]; then
Expand Down