Skip to content

Conversation

@JackHicks02
Copy link
Contributor

No description provided.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A unit test would be great.

@JackHicks02
Copy link
Contributor Author

Test added, is it possible to run it on a ci action here?

@JackHicks02 JackHicks02 requested a review from itzg November 2, 2025 23:10
@itzg
Copy link
Owner

itzg commented Nov 3, 2025

Test added, is it possible to run it on a ci action here?

Yep. It makes me approve the CI build first.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests. All looks great.

@itzg itzg merged commit 06e6bab into itzg:master Nov 3, 2025
1 check passed
@itzg
Copy link
Owner

itzg commented Nov 3, 2025

@itzg
Copy link
Owner

itzg commented Nov 3, 2025

Now it just needs to be bumped here

https://github.com/itzg/docker-minecraft-server/blob/6a8bcffa17c1e5412ae5d261a0f72ffdf4a1f1c0/Dockerfile#L52

And mention the glob option in CurseForge and Modrinth docs here

https://github.com/itzg/docker-minecraft-server/tree/master/docs/types-and-platforms/mod-platforms

@JackHicks02
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants