feat: overriding BACKUP_NAME and set RESTIC_HOSTNAME
#274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change as users with `mcbackup.backupMethod: restic` must set this new field. `resticHostname` sets the `RESTIC_HOSTNAME` environment variable with is used by restic to determine the previous snapshot aswell as for things like `restic forget` that group snapshots based on the hostname.
itzg
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to / part of itzg/docker-mc-backup#247
This contains a breaking change: the new
mcbackup.resticHostnamefield is required for users ofmcbackup.backupMethod: restic.I think that it is sensible to require the
mcbackup.resticHostnameinstead of defaulting to e.g.,minecraftServer.worldSaveNameas this could have a side effect in the grouping of the restic snapshots and thus could lead to unexpected deletion of snapshots.