fix 'PathPrefix(/videoplayback)' in companion-traefik.md
#653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acording to: https://doc.traefik.io/traefik/routing/routers/#path-pathprefix-and-pathregexp the correct syntax would be just PathPrefix(`/videoplayback`)
Contributor
|
Hiya @FawkesOficial, To be fair, in other configs I've done with Traefik in general, PathPrefix works better with a wildcard at the end instead of without. I've checked the videplayback endpoint and it seems that it has the arguments at the end of the URL and I thought that Traefik wouldn't take them and put the wildcard as a precaution, just like in the Caddy config (the Caddy config has the wildcard at the end). I've tried your suggested config and it works as well. Thanks for letting me know ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acording to:
https://doc.traefik.io/traefik/routing/routers/#path-pathprefix-and-pathregexp
the correct syntax would be just "PathPrefix(
/videoplayback)" and not "PathPrefix(/videoplayback*)".was "PathPrefix(
/videoplayback*)" intentional for some reason @auralglow ?