makefile: Add uninstall target + add check arg #5129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alindt
commented
Dec 30, 2024
alindt
commented
- add uninstall target
- restructure and rename targets and vars
- add uninstall target - restructure and rename targets and vars
unixfox
requested changes
Dec 31, 2024
|
|
||
| format: | ||
| crystal tool format | ||
| $(CRYSTAL_BIN) tool format --check |
Member
There was a problem hiding this comment.
Would prefer to have a separate arg for --check
Author
There was a problem hiding this comment.
Separate arg or a different target altogether maybe?
Member
There was a problem hiding this comment.
not very familiar with makefiles but I guess separate arg
unixfox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.