Skip to content

Fix untranslatable strings#2311

Merged
ivan-hc merged 1 commit intoivan-hc:mainfrom
cheack:fix-missing-translations
May 1, 2026
Merged

Fix untranslatable strings#2311
ivan-hc merged 1 commit intoivan-hc:mainfrom
cheack:fix-missing-translations

Conversation

@cheack
Copy link
Copy Markdown
Contributor

@cheack cheack commented May 1, 2026

While working on the Russian translation, I noticed that some strings never appeared translated.

In a previous discussion, one of these strings (No apps to update here!) was pointed out as already translatable - but it was actually using $'...', so it was never being translated.

This PR replaces $'...' with $"..." for all strings that are intended to be localized, and adds the corresponding translation entries for all supported languages.

@cheack
Copy link
Copy Markdown
Contributor Author

cheack commented May 1, 2026

I also noticed a multi-line output block in _install_sandbox_script (sandboxes.am) that uses the same pattern, but left it out of this PR - it's split across many small printf calls for ANSI color formatting, and translating those tiny fragments in isolation didn't seem right.

@ivan-hc
Copy link
Copy Markdown
Owner

ivan-hc commented May 1, 2026

AM-INSTALLER does not uses translations... but no matters.

@ivan-hc
Copy link
Copy Markdown
Owner

ivan-hc commented May 1, 2026

I also noticed a multi-line output block in _install_sandbox_script (sandboxes.am) that uses the same pattern, but left it out of this PR - it's split across many small printf calls for ANSI color formatting, and translating those tiny fragments in isolation didn't seem right.

Some blocks are a mess.

When translation support was added, $ were added wherever was available a message, or a echo or printf, without considering the possibility of made those messages even shorter and less complicated to translate.

Actually AM has hundreds of lines, containing ASCII characters and symbols.

I would made them easier to translate... but I don't want to overwrite already existing translations of other users.

@ivan-hc
Copy link
Copy Markdown
Owner

ivan-hc commented May 1, 2026

Man, you did an amazing job. Congratulations!

@ivan-hc ivan-hc merged commit 9a7f2cd into ivan-hc:main May 1, 2026
@cheack
Copy link
Copy Markdown
Contributor Author

cheack commented May 2, 2026

Haha, thanks!

@ivan-hc
Copy link
Copy Markdown
Owner

ivan-hc commented May 11, 2026

@cheack I don't know what's happened but I had to fix some lines containing quotes that were marked as invalid due to mismatches between original and translations

2844fba

For example, if the original had ", the translation had not " escaped.

Maybe because they were in single quote before, and you fixed the original, and not thee translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants