Add LAPACK banded LU/solve interface declarations (single + double precision)#31
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/d57763e0-309f-425d-981d-e9b5c4917ba3 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
ivan-pi
May 8, 2026 20:54
View session
ivan-pi
requested changes
May 8, 2026
Owner
There was a problem hiding this comment.
@copilot The LAPACK routines are not guaranteed pure, we can remove those attribtues.
Instead of placing one parameter on each line, I want to fold dummy arguments that share the same type and intent on the same line, as far as that is possible. This keeps the code shorter.
Contributor
Author
There was a problem hiding this comment.
Updated in d3a4d09: removed pure from the LAPACK interface procedures and folded dummy declarations by shared type/intent where possible in src/stiff3_linalg.f90.
Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/fd2af19c-bad3-4516-b368-62491b6b28e6 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
ivan-pi
requested changes
May 8, 2026
Comment on lines
+31
to
+33
| real(sp), intent(inout) :: a(lda,*) | ||
| integer, intent(out) :: ipiv(*) | ||
| integer, intent(out) :: info | ||
| integer, intent(in) :: m | ||
| integer, intent(in) :: n | ||
| integer, intent(in) :: lda | ||
| integer, intent(out) :: ipiv(*), info | ||
| integer, intent(in) :: m, n, lda |
Owner
There was a problem hiding this comment.
@copilot the integer sizes: m, n, lda, should be the second statement within the interface, before the argument a
Contributor
Author
There was a problem hiding this comment.
Done in 19ff182: m, n, lda are now declared immediately after import and before a(lda,*) in sgetrf/dgetrf. UI screenshot: N/A (no UI changes).
Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/4627e9eb-b7df-491d-9fb3-5202f9bbbcf3 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
Contributor
Author
Updated in 19ff182: integer size dummies are now declared before any dependent array dummies throughout the LAPACK interfaces in |
ivan-pi
approved these changes
May 8, 2026
ivan-pi
approved these changes
May 8, 2026
Copilot AI
added a commit
that referenced
this pull request
May 8, 2026
…ecision) (#31) * Add LAPACK banded solver interface blocks in linalg module Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/d57763e0-309f-425d-981d-e9b5c4917ba3 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> * Apply review feedback on LAPACK interface declarations Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/fd2af19c-bad3-4516-b368-62491b6b28e6 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> * Reorder LAPACK interface size declarations before dependent arrays Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/4627e9eb-b7df-491d-9fb3-5202f9bbbcf3 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
ivan-pi
added a commit
that referenced
this pull request
May 8, 2026
… table (#29) * chore: bump versions to 0.2.0 and add releases table to README Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/7b30eba2-f07d-45ed-a5f7-8da6cb98b014 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> * docs: add upcoming 0.2 release line to releases table Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/7b30eba2-f07d-45ed-a5f7-8da6cb98b014 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> * docs: enrich release table with highlights and releases link Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/92cb19b3-dbfc-4e65-9419-c8f448b14202 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> * docs: apply suggested 0.2 release highlight wording Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/9b4b2cd0-2173-4432-9d28-ac79d50ad670 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> * Add LAPACK banded LU/solve interface declarations (single + double precision) (#31) * Add LAPACK banded solver interface blocks in linalg module Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/d57763e0-309f-425d-981d-e9b5c4917ba3 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> * Apply review feedback on LAPACK interface declarations Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/fd2af19c-bad3-4516-b368-62491b6b28e6 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> * Reorder LAPACK interface size declarations before dependent arrays Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/4627e9eb-b7df-491d-9fb3-5202f9bbbcf3 Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> * Revise README for clarity Updated the README to clarify the library's purpose. Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com> Co-authored-by: Ivan Pribec <ivan.pribec@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/stiff3_linalg.f90