Skip to content

Conversation

@zimond
Copy link
Contributor

@zimond zimond commented Oct 25, 2019

This PR adds two modifications:

  1. Add NaiveDateTime to Value conversion
  2. Use local dependencies of dao and codegen. This is important because currently rustorm depends on crate.io distributed dao & codegen. This makes depending on the git branch impossible. Thus generally considered as anti-pattern.

By the way, [replace] is not used when rustorm is introduced as a lib dependency. So it's also removed.

@ivanceras ivanceras merged commit 8ac1313 into ivanceras:master Oct 25, 2019
@ivanceras
Copy link
Owner

My setup is rustorm is a part of another bigger project diwata hence the replace is working on my end. This change would make rustorm be used independently.

Thank you for the PRs

@zimond
Copy link
Contributor Author

zimond commented Oct 27, 2019

@ivanceras hey, after the new release I realized that codegen is also using hard-coded version of dao. A PR is too heavy for this. Maybe you could change that too, thanks

@zimond
Copy link
Contributor Author

zimond commented Oct 27, 2019

@ivanceras also please release a new version of rustorm-dao, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants