Skip to content

feat(core/scanner): finalize integration#157

Draft
ivangabriele wants to merge 28 commits intomainfrom
ivan/feat-core-scanner-finalize-integration
Draft

feat(core/scanner): finalize integration#157
ivangabriele wants to merge 28 commits intomainfrom
ivan/feat-core-scanner-finalize-integration

Conversation

@ivangabriele
Copy link
Owner

@ivangabriele ivangabriele commented Sep 15, 2024

Description

Finalize all core modules related to the Scanner feature, including its complete Webview integration.

Checklist

  • I updated the documentation accordingly. Or I don't need to.
  • I updated the tests accordingly. Or I don't need to.

@ivangabriele ivangabriele added os:debian os:windows os:macos feature:approved Approved new feature or feature enhancement. labels Sep 15, 2024
@ivangabriele ivangabriele added this to the v0.4 milestone Sep 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 10.87719% with 254 lines in your changes missing coverage. Please review.

Project coverage is 28.20%. Comparing base (197567a) to head (46d6aea).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
src-tauri/src/modules/cloud/utils.rs 0.00% 66 Missing ⚠️
src-tauri/src/modules/scanner/state.rs 0.00% 23 Missing ⚠️
src-tauri/src/modules/cloud/state.rs 0.00% 21 Missing ⚠️
src/libs/CoreStateHub/index.ts 0.00% 20 Missing ⚠️
src-tauri/src/modules/scanner/commands.rs 0.00% 18 Missing ⚠️
src-tauri/src/libs/helpers.rs 0.00% 17 Missing ⚠️
src-tauri/config/src/constants.rs 5.88% 16 Missing ⚠️
src-tauri/src/modules/scanner/utils.rs 0.00% 14 Missing ⚠️
src-tauri/src/copilot/commands.rs 0.00% 13 Missing ⚠️
src-tauri/src/libs/cli.rs 0.00% 13 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   31.76%   28.20%   -3.57%     
==========================================
  Files          33       42       +9     
  Lines         872     1092     +220     
  Branches       15       16       +1     
==========================================
+ Hits          277      308      +31     
- Misses        595      784     +189     
Flag Coverage Δ
core 27.53% <1.76%> (-5.47%) ⬇️
webview 32.63% <46.55%> (+11.94%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ivangabriele ivangabriele force-pushed the ivan/feat-core-scanner-finalize-integration branch from 3fe2658 to 88eb5b3 Compare November 2, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:approved Approved new feature or feature enhancement. os:debian os:macos os:windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants