fix: add await to BrowserCache.get calls in total hooks#87
Merged
IvanildoBarauna merged 1 commit intomainfrom Mar 4, 2026
Merged
fix: add await to BrowserCache.get calls in total hooks#87IvanildoBarauna merged 1 commit intomainfrom
IvanildoBarauna merged 1 commit intomainfrom
Conversation
BrowserCache.get is async (IndexedDB) since the localStorage→IndexedDB migration. The total hooks were calling it without await, causing a Promise<T | null> to be passed directly to setState instead of the resolved value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
awaitnas chamadas aBrowserCache.get()nos hooksuseTotalEducation,useTotalExperienceeuseTotalProjectsBrowserCache.geté assíncrono (IndexedDB) desde a migração localStorage→IndexedDB (PR Migrate cache service from localStorage to IndexedDB #84), mas os hooks foram adicionados sem oawait, fazendoPromise<T | null>ser passada diretamente aosetStateRoot cause
O commit
e1e08ddmigroucacheService.tspara IndexedDB tornandoBrowserCache.get()assíncrono. Os hooks desta branch foram criados com base na API síncrona (localStorage) e não incluíamawait.Test plan
npm run buildexecutado localmente sem erros de TypeScript🤖 Generated with Claude Code