Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds build support for a Go 1.26 devcontainer image by extending the Docker bake configuration.
Changes:
- Add a new
go_126Docker bake target that buildsghcr.io/ivanklee86/devcontainer/go:1.26. - Include
go_126in the default bake group so it’s built bytask bake/task bake:push.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docker-bake.hcl |
Adds a go_126 target with GO_VERSION=1.26, tags, and cache configuration; adds it to the default group. |
devcontainer_configs/bases/.gitinclude |
Referenced in the provided PR file list, but no diff/content was available to review here. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
7
| group "default" { | ||
| targets = [ | ||
| "base", | ||
| "python", | ||
| "go_125", | ||
| "go_126", | ||
| ] |
There was a problem hiding this comment.
PR title says "Add devcontainer for Go 1.26", but the actual change here only adds a new Docker bake target/image tag (no accompanying devcontainer config updates). Either adjust the PR title/description to reflect that this is just an image build target, or include the devcontainer configuration changes needed to consume the new go:1.26 image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.