refactor(frontend): improve SyncStatusButton UX with smooth async#44
Merged
Conversation
…uence and toast feedback
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



✨ What’s Changed?
Refactored the
SyncStatusButton.vuecomponent to provide a more polished and reliable synchronization experience:handleRefreshmethod is nowasyncand correctly awaitsqueryClient.invalidateQueries().Promise.allandsetTimeout. This ensures that even for very fast network responses, the refresh icon performs a deliberate, smooth rotation instead of a high-speed flash.useEnhancedToastto provide contextual feedback:silentflag on caught errors and updated the global error handler inApp.vueto respect it, preventing redundant notifications for the same event.isSyncingwith TanStack'suseIsFetchingto maintain a consistent UI state during the entire refresh sequence.🧪 How to Test It
npm run test:unit -- SyncStatusButton.spec.tsin thefrontenddirectory.📂 Scope
📝 Notes (Optional)
Added a new unit test file
SyncStatusButton.spec.tsto ensure the async logic and toast triggering are correctly verified.✅ Checklist