Refactor error handling for emit function in example from README#5
Merged
ivklgn merged 1 commit intoivklgn:mainfrom Nov 8, 2024
Merged
Refactor error handling for emit function in example from README#5ivklgn merged 1 commit intoivklgn:mainfrom
ivklgn merged 1 commit intoivklgn:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the error handling approach in the README's usage example by replacing direct type casting with a type guard (
isConwayError).Previously,
(error as IConwayError).emit(error)was used, but this change now checks for aConwayErrortype using if(isConwayError(error)) { error.emit(error); }.This modification enhances type safety and improves readability for consumers of the library.